[Mesa-dev] [PATCH demos] egl: Remove demos using EGL_MESA_screen_surface.

[Andreas Boll]

2015-09-01 18:55 GMT+02:00 Matt Turner <mattst88 at gmail.com>:
> On Tue, Sep 1, 2015 at 9:42 AM, Andreas Boll <andreas.boll.dev at gmail.com> wrote:
>> Hi Matt,
>>
>> 2015-08-29 1:09 GMT+02:00 Matt Turner <mattst88 at gmail.com>:
>>> The remnants of the extension were removed from Mesa in commit 7a58262e.
>>>
>>> Bugzilla: https://bugs.gentoo.org/show_bug.cgi?id=555186
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91020
>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91643
>>
>> Bugzilla: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=796373
>>
>> Unfortunately this patch isn't enough to fix the build on Debian:
>>
>> eglut.c: In function '_eglutDestroyWindow':
>> eglut.c:80:32: error: 'EGL_SCREEN_BIT_MESA' undeclared (first use in
>> this function)
>>         _eglut->surface_type != EGL_SCREEN_BIT_MESA)
>>                                 ^
>> eglut.c:80:32: note: each undeclared identifier is reported only once
>> for each function it appears in
>> eglut.c: In function '_eglutCreateWindow':
>> eglut.c:178:9: error: 'EGL_SCREEN_BIT_MESA' undeclared (first use in
>> this function)
>>     case EGL_SCREEN_BIT_MESA:
>>          ^
>> eglut.c: In function 'eglutDestroyWindow':
>> eglut.c:293:33: error: 'EGL_SCREEN_BIT_MESA' undeclared (first use in
>> this function)
>>     if ( _eglut->surface_type != EGL_SCREEN_BIT_MESA)
>>                                  ^
>>
>> git grep EGL_SCREEN_BIT_MESA
>> src/egl/eglut/eglut.c:       _eglut->surface_type != EGL_SCREEN_BIT_MESA)
>> src/egl/eglut/eglut.c:   case EGL_SCREEN_BIT_MESA:
>> src/egl/eglut/eglut.c:   if ( _eglut->surface_type != EGL_SCREEN_BIT_MESA)
>>
>>
>> Thanks,
>> Andreas.
>
> Thanks Andreas. I came to the same conclusion. I'll squash a patch to
> remove the uses from eglut.c as well.

With this patch [1] squashed in:

Reviewed-by: Andreas Boll <andreas.boll.dev at gmail.com>
Tested-by: Andreas Boll <andreas.boll.dev at gmail.com>


[1] https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ae997dc2325c0b74ad1c9b6ee8542d44354c60b4