[Mesa-dev] [PATCH 00/12] bmake inspired fixes

[Matt Turner]

On Tue, Sep 1, 2015 at 6:41 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> If you'd like some objective justification why these patches make
> things better, please give me some merits that I can check against.

As I've stated... quite a few times now, I don't like that the series
removes the AM_V_LEX/AM_V_YACC when they've caused no problems, I
don't like that the series removes a GNU make construct simply because
it is a GNU make construct [half of the others].

I also haven't heard any reasons why making the build system
compatible with BSD make is a useful thing to do -- and justification
is a required part of getting a patch accepted.

To be honest I'm so tired of dealing with this that I'm just going to
ignore the lack of justification and review it.


[01/12] mapi: automake: inline glapi_gen_mapi define

I don't like it. Push it anyway after you fix the indentation of the
second line to match 04/12.

[02/12] xmlpool: remove LOCALEDIR variable/fix bmake

I don't feel I understand the implications.

[03/12] util: automake: rework the format_srgb.c rule

Reviewed-by: Matt Turner <mattst88 at gmail.com>

[04/12] mapi: automake: rework the *api/glapi_mapi_tmp.h rules

Reviewed-by: Matt Turner <mattst88 at gmail.com>

[05/12] mapi: automake: rework the source generation rules

Reviewed-by: Matt Turner <mattst88 at gmail.com>

[06/12] mesa: automake: rework the source generation rules

Reviewed-by: Matt Turner <mattst88 at gmail.com>

[07/12] glsl: automake: remove custom AM_V_LEX/YACC

Not interested

[08/12] glsl: automake: rework the sources generation rules

Requires rebasing if 06/12 is dropped. Seems fine then.

[09/12] glsl: automake: reuse $(NIR_GENERATED_FILES) where possible

Reviewed-by: Matt Turner <mattst88 at gmail.com>

[10/12] glsl: build: use makefile.sources variables when possible

Reviewed-by: Matt Turner <mattst88 at gmail.com>

[11/12] glsl: build: remove bogus dependency

Reviewed-by: Matt Turner <mattst88 at gmail.com>

[12/12] auxiliary: fix the generated sources rules

No idea what this one is doing.

> Alternatively I'll push these within a few days.

Given the number of times I've previously expressed to you that I
didn't like the series, I think that would be improper.