[Mesa-dev] [PATCH 2/2] Revert "glsl: check total count of multi-slot double vertex attribs"

Dave Airlie airlied at gmail.com
Tue Sep 1 16:20:24 PDT 2015


On 2 September 2015 at 08:57, Matt Turner <mattst88 at gmail.com> wrote:
> This reverts commit ad208d975a6d3aebe14f7c2c16039ee200d8b30c.
>
> This code attempted to ensure that we didn't use more than the maximum
> number of attribute slots, but it did not consider attribute aliasing so
> it would miscount slots used by aliased attributes and incorrectly
> reject valid shaders.
>
> Worse, the code to handle attribute double slots was just working around
> a mistake in count_attribute_slots() (Fixed by previous patch).

that wasn't a mistake :-)

Dave.


More information about the mesa-dev mailing list