[Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

[Matt Turner]

On Wed, Sep 2, 2015 at 1:43 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> On Wednesday, September 02, 2015 02:26:55 AM Marek Olšák wrote:
>> From: Marek Olšák <marek.olsak at amd.com>
>>
>> People are having issues with apps because drirc wasn't installed
>> into /etc. I've lost patience.
>> ---
>>  src/mesa/drivers/dri/common/Makefile.am      |   4 +-
>>  src/mesa/drivers/dri/common/Makefile.sources |   3 +-
>>  src/mesa/drivers/dri/common/drirc            |  84 --------------------
>>  src/mesa/drivers/dri/common/drirc_built_in.h | 111 +++++++++++++++++++++++++++
>>  src/mesa/drivers/dri/common/xmlconfig.c      |  30 +++++++-
>>  5 files changed, 140 insertions(+), 92 deletions(-)
>>  delete mode 100644 src/mesa/drivers/dri/common/drirc
>>  create mode 100644 src/mesa/drivers/dri/common/drirc_built_in.h
>
> I really dislike this idea, but I understand your frustration.  Distros
> often seem to ship bunk /etc/drirc files.
>
> It seems that "make install" doesn't actually install /etc/drirc today.
> Fixing that would probably go a long way in helping this problem...

What makes you think that?

It's definitely installed in Gentoo, and I don't see any special code
in the ebuild to handle it.

src/mesa/drivers/dri/common/Makefile.am contains

   sysconf_DATA = drirc

which should install it to /etc -- it appears to work because I see

 /usr/bin/install -c -m 644
/var/tmp/portage/media-libs/mesa-11.0.0_rc2/work/mesa-11.0.0-rc2/src/mesa/drivers/dri/common/drirc
'/var/tmp/portage/media-libs/mesa-11.0.0_rc2/image//etc'

in my build.log.

If other distributions are screwing this up, that's not our build
system's fault as far as I can tell.