[Mesa-dev] [PATCH 1/2] dri/common: embed drirc into driver binaries

[Ilia Mirkin]

On Thu, Sep 3, 2015 at 3:30 PM, Marek Olšák <maraeo at gmail.com> wrote:
> It looks like the comments have mostly been negative. If I get any
> other bugs related to this, I'll have to resort to using setenv in the
> driver to get the behavior that should be the default.
>
> There are 2 unresolved issues though:
>
> 1) The location is hardcoded to /etc/drirc in xmlconfig.c. Installing
> Mesa to a different location should also install drirc there and load
> it from there.

Solution is to use sysconfigdir instead of /etc.

>
> 2) Using LIBGL_DRIVERS_PATH won't use the correct drirc file. The only
> remaining solution to that is to kill LIBGL_DRIVERS_PATH.

I've always suggested that people do "make install" and
LD_LIBRARY_PATH instead of this LIBGL_DRIVERS_PATH hack. IMHO that
only leads to confusion.

>
> Opinions?
>
> Marek
>
>
> On Thu, Sep 3, 2015 at 8:26 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
>> On Wednesday, September 02, 2015 02:38:38 PM Matt Turner wrote:
>>> On Wed, Sep 2, 2015 at 1:43 PM, Kenneth Graunke <kenneth at whitecape.org> wrote:
>>> > On Wednesday, September 02, 2015 02:26:55 AM Marek Olšák wrote:
>>> >> From: Marek Olšák <marek.olsak at amd.com>
>>> >>
>>> >> People are having issues with apps because drirc wasn't installed
>>> >> into /etc. I've lost patience.
>>> >> ---
>>> >>  src/mesa/drivers/dri/common/Makefile.am      |   4 +-
>>> >>  src/mesa/drivers/dri/common/Makefile.sources |   3 +-
>>> >>  src/mesa/drivers/dri/common/drirc            |  84 --------------------
>>> >>  src/mesa/drivers/dri/common/drirc_built_in.h | 111 +++++++++++++++++++++++++++
>>> >>  src/mesa/drivers/dri/common/xmlconfig.c      |  30 +++++++-
>>> >>  5 files changed, 140 insertions(+), 92 deletions(-)
>>> >>  delete mode 100644 src/mesa/drivers/dri/common/drirc
>>> >>  create mode 100644 src/mesa/drivers/dri/common/drirc_built_in.h
>>> >
>>> > I really dislike this idea, but I understand your frustration.  Distros
>>> > often seem to ship bunk /etc/drirc files.
>>> >
>>> > It seems that "make install" doesn't actually install /etc/drirc today.
>>> > Fixing that would probably go a long way in helping this problem...
>>>
>>> What makes you think that?
>>
>> My mistake - apparently I didn't bother to set --sysconfdir properly, so
>> my "make DESTDIR=/tmp/foo install" put it in /tmp/foo/usr/local/etc/,
>> which I wasn't expecting.
>>
>> So you're right, "make install" does install it.
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev