[Mesa-dev] [PATCH 04/12] i965: Move legacy clip plane handling to vec4_vs_visitor.

Kenneth Graunke kenneth at whitecape.org
Thu Sep 3 15:47:21 PDT 2015


On Saturday, August 29, 2015 02:23:58 AM Kenneth Graunke wrote:
> This is now only used for the vertex shader, so it makes sense to get it
> out of any paths run by the geometry shader.
> 
> By wrapping the run() method, we can eliminate the bogus NULL
> parameter in the GS case, and do VS things only for the VS.

This bit of the commit message is bunk, from a previous version of the
patch where I actually added separate run() methods to each subclass.

I've replaced the "By wrapping the run()..." text with:

"Instead of passing the gl_clip_plane array into the run() method (which 
 is shared among all subclasses), we add it as a vec4_vs_visitor 
 constructor parameter.  This eliminates the bogus NULL parameter in the
 GS case."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150903/c4f48ac1/attachment.sig>


More information about the mesa-dev mailing list