[Mesa-dev] [Mesa-stable] [PATCH] vc4: Initialize pack field of qreg to 0 in qir_get_temp

[Eric Anholt]

Emil Velikov <emil.l.velikov at gmail.com> writes:

> On 26 August 2015 at 12:52, Boyan Ding <boyan.j.ding at gmail.com> wrote:
>> This avoids generation of undefined packing in qir and qpu instructions,
>> fixing a lot of rendering errors.
>>
>> Fixes 8b36d107fdd (vc4: Pack the unorm-packing bits into a src MUL
>> instruction when possible.)
>>
>> Cc: mesa-stable at lists.freedesktop.org
>> Signed-off-by: Boyan Ding <boyan.j.ding at gmail.com>
>> ---
>>  src/gallium/drivers/vc4/vc4_qir.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/src/gallium/drivers/vc4/vc4_qir.c b/src/gallium/drivers/vc4/vc4_qir.c
>> index 9d93071..12dedce 100644
>> --- a/src/gallium/drivers/vc4/vc4_qir.c
>> +++ b/src/gallium/drivers/vc4/vc4_qir.c
>> @@ -314,6 +314,7 @@ qir_get_temp(struct vc4_compile *c)
>>
>>          reg.file = QFILE_TEMP;
>>          reg.index = c->num_temps++;
>> +        reg.pack = 0;
>>
> Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
>
> Eric, would you mind if we commit this ? It's been around a week and
> it's dead trivial.

Pushed with my review too.

Sorry for the delay!  I've been off in terrible kernel land, again.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150904/e6284d3a/attachment.sig>