[Mesa-dev] [PATCH v4 0/3] A couple of fixes for Tex(Sub)Image error checks

[Mark Janes]

Mark Janes <mark.a.janes at intel.com> writes:

> By my count, this series fixes 59 separate dEQP tests on various

I incorrectly attributed 54 of those test fixes to this patch series.  I
had applied this patch on top of Iago's
96ea1663082c4a17eaf59873190f1e9677623d91, which also improved dEQP.

> platforms.  I found no regressions.
>
> Tested-by: Mark Janes <mark.a.janes at intel.com>
>
> Eduardo Lima Mitev <elima at igalia.com> writes:
>
>> This is a new version of the mini-series that fixes the regression described at https://bugs.freedesktop.org/show_bug.cgi?id=91582.
>>
>> The first patch is not directly related with fixing the regression, but it addresses an issue uncovered by it and at the same time fixes a failing dEQP test.
>>
>> The second patch is simply moving a function from teximage to glformats, because it will be used by another function in the latter file. And since teximage already uses API from glformats, it makes sense.
>>
>> I tested the series for piglit, and for the functional dEQP-GLES2 and dEQP-GLES3 suites. No regressions detected. There are 5 tests fixed for GLES2, and 1 test fixed for GLES3. Lets see if I got it right this time.
>>
>> cheers,
>>
>> Eduardo Lima Mitev (3):
>>   mesa: Fix order of format+type and internal format checks for
>>     glTexImageXD ops
>>   mesa: Move _mesa_base_tex_format() from teximage to glformats files
>>   mesa: Use the effective internal format instead for validation
>>
>>  src/mesa/main/glformats.c | 632 ++++++++++++++++++++++++++++++++++++++++++++++
>>  src/mesa/main/glformats.h |   2 +
>>  src/mesa/main/teximage.c  | 564 +++--------------------------------------
>>  src/mesa/main/teximage.h  |   4 -
>>  4 files changed, 665 insertions(+), 537 deletions(-)
>>
>> -- 
>> 2.4.6
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev