[Mesa-dev] [PATCH v2] gbm: convert gbm bo format to fourcc format on dma-buf import

[Emil Velikov]

Hello Ray,

On 28 August 2015 at 19:50, Ray Strode <halfline at gmail.com> wrote:
> From: Ray Strode <rstrode at redhat.com>
>
> At the moment if a gbm buffer is imported and the gbm buffer
> has an old-style GBM_BO_FORMAT format, the import will crash,
> since it's passed directly to DRI functions that expect
> a fourcc format (as provided by the newer GBM_FORMAT
> definitions)
>
> This commit addresses the problem in two ways:
>
> 1) it prevents invalid formats from leading to a crash by
> returning EINVAL if the image couldn't be created
>
> 2) it translates GBM_BO_FORMAT formats into the comparable
> GBM_FORMAT formats.

I'm not Kristian or Ander, yet your patch looks great imho.
Have you seen an application where this causes problems ? Might if I
add it to the commit log before pushing ?

CC: "10.6 11.0" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

Thanks
Emil