[Mesa-dev] [PATCH] r600: don't use shader key without verifying shader type

Dave Airlie airlied at gmail.com
Mon Sep 7 15:50:51 PDT 2015


On 8 September 2015 at 08:46, Dave Airlie <airlied at gmail.com> wrote:
> On 8 September 2015 at 08:38, Dave Airlie <airlied at gmail.com> wrote:
>> From: Dave Airlie <airlied at redhat.com>
>>
>> Since 7a32652231f96eac14c4bfce02afe77b4132fb77
>> r600: Turn 'r600_shader_key' struct into union
>>
>> we were accessing key fields that might be aliased in the union
>> with other fields, so we should check what shader type we are
>> compiling for before using key values from it.
>>
>
> This version contains two little bugs extra brace got left over and a
> . should be a _
>
> Doh, but otherwise it'll be the version that compiles I push :)
>

Okay this doesn't work for more reasons, I'm going to wake up a bit,
and maybe try again!

Dave.


More information about the mesa-dev mailing list