[Mesa-dev] [PATCH 2/3] radeonsi: only do depth-only or stencil-only in-place decompression

Michel Dänzer michel at daenzer.net
Wed Sep 9 01:09:11 PDT 2015


On 07.09.2015 07:17, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
> 
> instead of always doing both.
> Usually, only depth is needed, so stencil decompression is useless.

[...]

> @@ -247,6 +256,7 @@ void si_flush_depth_textures(struct si_context *sctx,
>  		assert(tex->is_depth && !tex->is_flushing_texture);
>  
>  		si_blit_decompress_depth_in_place(sctx, tex,
> +						  ((struct si_sampler_view*)view)->is_stencil_sampler,

This cast is a bit ugly, please use a separate local variable of type
struct si_sampler_view* for this.


With that fixed,

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


Correspondingly for patch 3.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


More information about the mesa-dev mailing list