[Mesa-dev] [PATCH 0/9] Implement textureQueryLod in softpipe

[Brian Paul]

On 09/09/2015 04:35 AM, Krzesimir Nowak wrote:
> The following patches do some preparatory refactoring in softpipe's
> sp_tex_sample.{c,h} before actually implementing the feature.
>
> There is also a patch that fixes softpipe's textureLod with bias. I
> caught this bug when finished the textureQueryLod implementation - one
> of four textureQueryLod tests were failing because of it. I sent
> patches adding the testcases with non-zero lod-bias value to piglit
> mailing list
> (http://lists.freedesktop.org/archives/piglit/2015-September/017018.html).
>
> Also, this is my first contribution to mesa, but I hope I didn't make
> any obvious mistakes.
>
> Thanks.
>
> Krzesimir Nowak (9):
>    tgsi: Remove trailing backslash in comment
>    softpipe: Fix textureLod with nonzero GL_TEXTURE_LOD_BIAS value.
>    softpipe: Split compute_lambda_lod into two functions
>    softpipe: Put mip_filter_func inside a struct
>    softpipe: Split code getting a filter into separate function
>    softpipe: Split 3D to 2D coords conversion into separate function.
>    softpipe: Add functions for computing mipmap level
>    tgsi: Add code for handling lodq opcode
>    softpipe: Implement and enable textureQueryLod
>
>   src/gallium/auxiliary/tgsi/tgsi_exec.c       |  46 +++-
>   src/gallium/auxiliary/tgsi/tgsi_exec.h       |  10 +
>   src/gallium/drivers/softpipe/sp_screen.c     |   2 +-
>   src/gallium/drivers/softpipe/sp_tex_sample.c | 338 +++++++++++++++++++++------
>   src/gallium/drivers/softpipe/sp_tex_sample.h |  32 ++-
>   5 files changed, 345 insertions(+), 83 deletions(-)
>

Overall, this looks really nice.  You did a good job of following the 
coding style and documenting your patches.

I just have some nitpicks on some of the patches that I'll post/reply 
on.  Basically, I think a few more things could be const-qualified and 
more comments on the new functions to explain what's going on would be 
helpful.

If you can clean up those minor things I'll commit the series for you.

Thanks!

-Brian