[Mesa-dev] [PATCH 2/4] svga: remove useless MAX2() call

Brian Paul brianp at vmware.com
Thu Sep 10 08:04:00 PDT 2015


The sum of two unsigned ints is always >= 0.  Found with Coverity.
---
 src/gallium/drivers/svga/svga_state_tss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/svga/svga_state_tss.c b/src/gallium/drivers/svga/svga_state_tss.c
index a13980d..5991da1 100644
--- a/src/gallium/drivers/svga/svga_state_tss.c
+++ b/src/gallium/drivers/svga/svga_state_tss.c
@@ -90,7 +90,7 @@ emit_tex_binding_unit(struct svga_context *svga,
       }
       else {
          last_level = MIN2(sv->u.tex.last_level, sv->texture->last_level);
-         min_lod = MAX2(0, (s->view_min_lod + sv->u.tex.first_level));
+         min_lod = s->view_min_lod + sv->u.tex.first_level;
          min_lod = MIN2(min_lod, last_level);
          max_lod = MIN2(s->view_max_lod + sv->u.tex.first_level, last_level);
       }
-- 
1.9.1



More information about the mesa-dev mailing list