[Mesa-dev] [PATCH v2 2/2] i965/vec4_nir: Load constants as integers

[Jason Ekstrand]

Please add the shader-db reults to the commit message.  With that,

Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>

Also, please CC stable on this one as well.  I think there's some bugs
without it.
--Jason

On Mon, Aug 24, 2015 at 4:51 AM, Antia Puentes <apuentes at igalia.com> wrote:
> Loads constants using integer as their register type, this is done
> for consistency with the FS backend.
> ---
>  src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp b/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp
> index 632e409..23b2fab 100644
> --- a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp
> @@ -456,7 +456,7 @@ void
>  vec4_visitor::nir_emit_load_const(nir_load_const_instr *instr)
>  {
>     dst_reg reg = dst_reg(GRF, alloc.allocate(1));
> -   reg.type =  BRW_REGISTER_TYPE_F;
> +   reg.type =  BRW_REGISTER_TYPE_D;
>
>     unsigned remaining = brw_writemask_for_size(instr->def.num_components);
>
> @@ -477,7 +477,7 @@ vec4_visitor::nir_emit_load_const(nir_load_const_instr *instr)
>        }
>
>        reg.writemask = writemask;
> -      emit(MOV(reg, src_reg(instr->value.f[i])));
> +      emit(MOV(reg, src_reg(instr->value.i[i])));
>
>        remaining &= ~writemask;
>     }
> --
> 2.1.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev