[Mesa-dev] [PATCH 0/7] Const fixes/cleanups in softpipe's tex samplers
Brian Paul
brianp at vmware.com
Fri Sep 11 14:08:26 PDT 2015
On 09/11/2015 12:07 PM, Krzesimir Nowak wrote:
> This stops abusing sp_sampler_view as a local storage and thus
> allowing to put some more const modifiers in front of some types.
>
> I might have gotten carried away too bit with the last commit. :) So
> if you don't like it, then please ignore it.
>
> Tested it with piglit shader tests and got no regressions.
>
> Krzesimir Nowak (7):
> softpipe: Move the faces array from view to filter_args
> softpipe: Constify some sampler and view parameters
> tgsi, softpipe: Constify tgsi_sampler in query_lod vfunc
> softpipe: Constify sampler and view parameters in img filters
> softpipe: Constify sampler and view parameters in mip filters
> softpipe: Constify sp_tgsi_sampler
> softpipe: Constify variables
>
> src/gallium/auxiliary/tgsi/tgsi_exec.h | 2 +-
> src/gallium/drivers/softpipe/sp_tex_sample.c | 663 +++++++++++++--------------
> src/gallium/drivers/softpipe/sp_tex_sample.h | 16 +-
> 3 files changed, 328 insertions(+), 353 deletions(-)
>
Series, LGTM. I'll commit/push with my R-b after a little bit of
testing here.
Thanks!
-Brian
More information about the mesa-dev
mailing list