[Mesa-dev] [PATCH 5/5] gallium: Remove pipe_rasterizer_state::line_last_pixel.

Jose Fonseca jfonseca at vmware.com
Mon Sep 14 04:09:54 PDT 2015


This state has been de-fact ignored all along.
---
 src/gallium/auxiliary/hud/hud_context.c    | 1 -
 src/gallium/auxiliary/util/u_dump_state.c  | 1 -
 src/gallium/docs/source/cso/rasterizer.rst | 4 ----
 src/gallium/drivers/trace/tr_dump_state.c  | 1 -
 src/gallium/include/pipe/p_state.h         | 1 -
 5 files changed, 8 deletions(-)

diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c
index 95eed26..b8950cc 100644
--- a/src/gallium/auxiliary/hud/hud_context.c
+++ b/src/gallium/auxiliary/hud/hud_context.c
@@ -1197,7 +1197,6 @@ hud_create(struct pipe_context *pipe, struct cso_context *cso)
    hud->rasterizer.bottom_edge_rule = 1;
    hud->rasterizer.depth_clip = 1;
    hud->rasterizer.line_width = 1;
-   hud->rasterizer.line_last_pixel = 1;
 
    /* vertex shader */
    {
diff --git a/src/gallium/auxiliary/util/u_dump_state.c b/src/gallium/auxiliary/util/u_dump_state.c
index 441d162..d3db092 100644
--- a/src/gallium/auxiliary/util/u_dump_state.c
+++ b/src/gallium/auxiliary/util/u_dump_state.c
@@ -352,7 +352,6 @@ util_dump_rasterizer_state(FILE *stream, const struct pipe_rasterizer_state *sta
    util_dump_member(stream, bool, state, line_stipple_enable);
    util_dump_member(stream, uint, state, line_stipple_factor);
    util_dump_member(stream, uint, state, line_stipple_pattern);
-   util_dump_member(stream, bool, state, line_last_pixel);
    util_dump_member(stream, bool, state, flatshade_first);
    util_dump_member(stream, bool, state, half_pixel_center);
    util_dump_member(stream, bool, state, bottom_edge_rule);
diff --git a/src/gallium/docs/source/cso/rasterizer.rst b/src/gallium/docs/source/cso/rasterizer.rst
index 8d473b8..3a65228 100644
--- a/src/gallium/docs/source/cso/rasterizer.rst
+++ b/src/gallium/docs/source/cso/rasterizer.rst
@@ -148,10 +148,6 @@ line_stipple_pattern
 line_stipple_factor
     When drawing a stippled line, each bit in the stipple pattern is
     repeated N times, where N = line_stipple_factor + 1.
-line_last_pixel
-    Controls whether the last pixel in a line is drawn or not.  OpenGL
-    omits the last pixel to avoid double-drawing pixels at the ends of lines
-    when drawing connected lines.
 
 
 Points
diff --git a/src/gallium/drivers/trace/tr_dump_state.c b/src/gallium/drivers/trace/tr_dump_state.c
index 9bf4a72..7b5172f 100644
--- a/src/gallium/drivers/trace/tr_dump_state.c
+++ b/src/gallium/drivers/trace/tr_dump_state.c
@@ -133,7 +133,6 @@ void trace_dump_rasterizer_state(const struct pipe_rasterizer_state *state)
    trace_dump_member(bool, state, multisample);
    trace_dump_member(bool, state, line_smooth);
    trace_dump_member(bool, state, line_stipple_enable);
-   trace_dump_member(bool, state, line_last_pixel);
 
    trace_dump_member(bool, state, flatshade_first);
 
diff --git a/src/gallium/include/pipe/p_state.h b/src/gallium/include/pipe/p_state.h
index 266ebba..6319fbe 100644
--- a/src/gallium/include/pipe/p_state.h
+++ b/src/gallium/include/pipe/p_state.h
@@ -105,7 +105,6 @@ struct pipe_rasterizer_state
    unsigned multisample:1;         /* XXX maybe more ms state in future */
    unsigned line_smooth:1;
    unsigned line_stipple_enable:1;
-   unsigned line_last_pixel:1;
 
    /**
     * Use the first vertex of a primitive as the provoking vertex for
-- 
2.1.4



More information about the mesa-dev mailing list