[Mesa-dev] [PATCH v2 2/4] nir: Add comments to nir_index_instrs and nir_index_ssa_defs

[Eduardo Lima Mitev]

On 09/15/2015 10:44 PM, Jason Ekstrand wrote:
> The provided indices have the very nice property that if A dominates B then
> A->index <= B->index.  We should document that somewhere.
> 
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/glsl/nir/nir.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/src/glsl/nir/nir.c b/src/glsl/nir/nir.c
> index 1ff8f21..23071ef 100644
> --- a/src/glsl/nir/nir.c
> +++ b/src/glsl/nir/nir.c
> @@ -1427,6 +1427,10 @@ index_ssa_block(nir_block *block, void *state)
>     return true;
>  }
>  
> +/**
> + * The indices are applied top-to-bottom which has the very nice property
> + * that, if A dominates B, then A->index <= B->index.
> + */
>  void
>  nir_index_ssa_defs(nir_function_impl *impl)
>  {
> @@ -1445,6 +1449,10 @@ index_instrs_block(nir_block *block, void *state)
>     return true;
>  }
>  
> +/**
> + * The indices are applied top-to-bottom which has the very nice property
> + * that, if A dominates B, then A->index <= B->index.
> + */
>  unsigned
>  nir_index_instrs(nir_function_impl *impl)
>  {
> 

Before pushing, this patch should be squashed with the previous one
(1/4), I think.

Eduardo