[Mesa-dev] [PATCH 1/2] nir: some comment fixups

Ilia Mirkin imirkin at alum.mit.edu
Thu Sep 17 17:57:41 PDT 2015


On Thu, Sep 17, 2015 at 8:48 PM, Rob Clark <robdclark at gmail.com> wrote:
> On Thu, Sep 17, 2015 at 8:35 PM, Dieter Nützel <Dieter at nuetzel-hh.de> wrote:
>> Am 18.09.2015 02:27, schrieb Rob Clark:
>>>
>>> On Thu, Sep 17, 2015 at 8:03 PM, Timothy Arceri <t_arceri at yahoo.com.au>
>>> wrote:
>>>>
>>>> On Thu, 2015-09-17 at 18:20 -0400, Rob Clark wrote:
>>>>> -   /** list of system value variables in the shader */
>>>>> +   /** list of system value variables in the shade (nir_variable)r
>>>>
>>>>
>>>>
>>>> The above comment is broken. With that fixed both patches are:
>>>>
>>>> Reviewed-by: Timothy Arceri <t_arceri at yahoo.com.au>
>>>
>>>
>>> oh, whoops.. thanks, fixed and pushed
>>>
>>> BR,
>>> -R
>>
>>
>> Rob,
>>
>> you committed the broken one...
>
> are you sure?
>
> http://cgit.freedesktop.org/mesa/mesa/commit/?id=ba78260b0fbd291618df63bc7a54be0a36148b40
>
> looks ok to me.. I assume 'broken' == the stray character that snuck
> in there but maybe I am missing something..  (it is quite possible
> that I am overdue for a new prescription of eye-glasses :-P)

Probably just need to wait out those hot autumn weeks until you're no
longer thinking of shade all the time...

  -ilia


More information about the mesa-dev mailing list