[Mesa-dev] [PATCH v3] i965/vec4: Change types as needed to propagate source modifiers using current instruction

[Alejandro Piñeiro]

On 18/09/15 20:00, Jason Ekstrand wrote:
>
>
> On Sep 18, 2015 10:09 AM, "Alejandro Piñeiro" <apinheiro at igalia.com
> <mailto:apinheiro at igalia.com>> wrote:
> >
> > SEL and MOV instructions, as long as they don't have source
> modifiers, are
> > just copying bits around.  So those kind of instruction could be
> propagated
> > even if there are type mismatches. This is needed because NIR generates
> > integer SEL and MOV instructions whenever it doesn't know what else to
> > generate.
> >
> > This commit adds support for copy propagation using current instruction
> > as reference.
> >
> > v2: include check for saturate, as Jason Ekstrand suggested
> > v3: check that the dst.type and the src type are the same, in order to
> >     solve (among others) the following deqp regression with v2:
> >    
> dEQP-GLES3.functional.shaders.operator.unary_operator.minus.lowp_uint_vertex
>
> Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com
> <mailto:jason.ekstrand at intel.com>>
>
> The other will take more thinking.
>

Taking into account that the second patch is more complex, and probably
a new update, I changed my mind, and I think that it would be better to
push them individually.

I have just pushed this one. Thanks for the review and patience.

BR

-- 
Alejandro Piñeiro (apinheiro at igalia.com)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150919/b7665ed7/attachment-0001.html>