[Mesa-dev] [PATCH 3/3] nir: rename nir_lower_samplers.c{pp,}

[Emil Velikov]

Hi Jason,

On 18 September 2015 at 18:52, Jason Ekstrand <jason at jlekstrand.net> wrote:
>
> On Sep 18, 2015 12:40 PM, "Emil Velikov" <emil.l.velikov at gmail.com> wrote:
>>
>> Thanks for the review/testing guys.
>>
>> Just noticed that some typos/strange wording
>>
>> On 17 September 2015 at 16:25, Emil Velikov <emil.l.velikov at gmail.com>
>> wrote:
>> > With the only C++ function having it's own wrapper we can 'demote' this
>> s/it's/its/
>>
>> > file to a normal C one. This allows us to get rid of extern C {
>> > support C99 designated initializers in CPP code.
>> >
>> This allows us to get rid of extern C { #include <foo.h> } 'hacks'.
>> Plus some of the headers may use C99 initializers, which are not
>> supported by the ISO standard.
>
> What headers are those?  All NIR headers should be C++ safe.
>
Silly me did not reply to the thread that inspired this series. Sorry
about that.

Recent patch from Timothy (ef8eebc6ad5 nir: support indirect indexing
samplers in struct arrays) added a nir_builder.h include. The latter
of which includes c99 initializers. Erik has a patch that reworks them
which looks good, but I'll let others decide for/against it.

I'll mention the header/offending commit in the commit message as well.

Thanks
Emil