[Mesa-dev] [PATCH] nir/builder: Don't use designated initializers

Kenneth Graunke kenneth at whitecape.org
Mon Sep 21 09:22:16 PDT 2015


On Monday, September 21, 2015 08:26:04 AM Jason Ekstrand wrote:
> Designated initializers are not allowed in C++ (not even C++11).  Since
> nir_lower_samplers is now using nir_builder, and nir_lower_samplers is in
> C++, this breaks the build on some compilers.  Aparently, GCC 5 allows it
> in some limited extent because mesa still builds on my system without this
> patch.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92052
> ---
>  src/glsl/nir/nir_builder.h | 21 ++++++++++++++++++---
>  1 file changed, 18 insertions(+), 3 deletions(-)

I'd rather just take Emil's patch to convert nir_lower_samplers out of
C++, honestly.  NIR is in C99, let's keep it that way.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150921/7c6bccb3/attachment.sig>


More information about the mesa-dev mailing list