[Mesa-dev] [PATCH 2/6] nir/lower_alu_to_scalar: Return after lower_reduction

Jason Ekstrand jason at jlekstrand.net
Tue Sep 22 18:18:12 PDT 2015


We don't use any of the code after the switch and, as far as I can tell, it
wouldn't work anyway.  The only reason this wasn't causing us problems is
that it's all dead and DCE cleans it up.
---
 src/glsl/nir/nir_lower_alu_to_scalar.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/glsl/nir/nir_lower_alu_to_scalar.c b/src/glsl/nir/nir_lower_alu_to_scalar.c
index 5ef5ec2..84d4943 100644
--- a/src/glsl/nir/nir_lower_alu_to_scalar.c
+++ b/src/glsl/nir/nir_lower_alu_to_scalar.c
@@ -86,7 +86,7 @@ lower_alu_instr_scalar(nir_alu_instr *instr, nir_builder *b)
    case name##3: \
    case name##4: \
       lower_reduction(instr, chan, merge, b); \
-      break;
+      return;
 
    switch (instr->op) {
    case nir_op_vec4:
-- 
2.5.0.400.gff86faf



More information about the mesa-dev mailing list