[Mesa-dev] [PATCH 3/7] mesa: Add extension enable for GL_OES_geometry_shader

[Eduardo Lima Mitev]

First line of commit message reads weird, what about:

mesa: Add GL_OES_geometry_shader to enabled extensions

On 09/23/2015 10:42 AM, Marta Lofstedt wrote:
> From: Marta Lofstedt <marta.lofstedt at intel.com>
> 
> Exposes the GL_OES_geometry_shader extension for OpenGL ES 3.1.
> 
> Signed-off-by: Marta Lofstedt <marta.lofstedt at linux.intel.com>
> ---
>  src/mesa/main/extensions.c              | 1 +
>  src/mesa/main/mtypes.h                  | 1 +
>  src/mesa/main/tests/dispatch_sanity.cpp | 3 +++
>  3 files changed, 5 insertions(+)
> 
> diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
> index b2c88c3..5cfcd43 100644
> --- a/src/mesa/main/extensions.c
> +++ b/src/mesa/main/extensions.c
> @@ -314,6 +314,7 @@ static const struct extension extension_table[] = {
>     { "GL_OES_fbo_render_mipmap",                   o(dummy_true),                                   ES1 | ES2, 2005 },
>     { "GL_OES_fixed_point",                         o(dummy_true),                                   ES1,       2002 },
>     { "GL_OES_framebuffer_object",                  o(dummy_true),                                   ES1,       2005 },
> +   { "GL_OES_geometry_shader",                     o(OES_geometry_shader),                               ES31, 2015 },
>     { "GL_OES_get_program_binary",                  o(dummy_true),                                         ES2, 2008 },
>     { "GL_OES_mapbuffer",                           o(dummy_true),                                   ES1 | ES2, 2005 },
>     { "GL_OES_packed_depth_stencil",                o(dummy_true),                                   ES1 | ES2, 2007 },
> diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
> index fac45aa..2886f19 100644
> --- a/src/mesa/main/mtypes.h
> +++ b/src/mesa/main/mtypes.h
> @@ -3770,6 +3770,7 @@ struct gl_extensions
>     GLboolean OES_texture_half_float;
>     GLboolean OES_texture_half_float_linear;
>     GLboolean OES_compressed_ETC1_RGB8_texture;
> +   GLboolean OES_geometry_shader;
>     GLboolean extension_sentinel;
>     /** The extension string */
>     const GLubyte *String;
> diff --git a/src/mesa/main/tests/dispatch_sanity.cpp b/src/mesa/main/tests/dispatch_sanity.cpp
> index 0ddda59..cce05d9 100644
> --- a/src/mesa/main/tests/dispatch_sanity.cpp
> +++ b/src/mesa/main/tests/dispatch_sanity.cpp
> @@ -2481,5 +2481,8 @@ const struct function gles31_functions_possible[] = {
>     /* GL_OES_texture_storage_multisample_2d_array */
>     { "glTexStorage3DMultisampleOES", 31, -1 },
>  
> +   /*GL_OES_geometry_shader*/

Blank spaces between comment brackets and "GL_OES_geometry_shader".

With this and clearer first line of commit log:

Reviewed-by: Eduardo Lima Mitev <elima at igalia.com>

> +   { "glFramebufferTextureOES", 31, -1},
> +
>     { NULL, 0, -1 },
>   };
>