[Mesa-dev] [PATCH 7/7] doc: Set GL_OES_geometry_shader as started

[Iago Toral]

On Wed, 2015-09-23 at 14:34 +0000, Lofstedt, Marta wrote:
> > -----Original Message-----
> > From: mesa-dev [mailto:mesa-dev-bounces at lists.freedesktop.org] On
> > Behalf Of Iago Toral
> > Sent: Wednesday, September 23, 2015 3:18 PM
> > To: Eduardo Lima Mitev
> > Cc: mesa-dev at lists.freedesktop.org
> > Subject: Re: [Mesa-dev] [PATCH 7/7] doc: Set GL_OES_geometry_shader as
> > started
> > 
> > On Wed, 2015-09-23 at 14:07 +0200, Eduardo Lima Mitev wrote:
> > > On 09/23/2015 10:42 AM, Marta Lofstedt wrote:
> > > > From: Marta Lofstedt <marta.lofstedt at intel.com>
> > > >
> > > > Signed-off-by: Marta Lofstedt <marta.lofstedt at linux.intel.com>
> > > > ---
> > > >    | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/docs/GL3.txt b/docs/GL3.txt index 92941cf..e1c6049
> > > > 100644
> > > > --- a/docs/GL3.txt
> > > > +++ b/docs/GL3.txt
> > > > @@ -238,7 +238,7 @@ GLES3.2, GLSL ES 3.2
> > > >    GL_OES_copy_image                                    not started (based on
> > GL_ARB_copy_image, which is done for some drivers)
> > > >    GL_OES_draw_buffers_indexed                          not started
> > > >    GL_OES_draw_elements_base_vertex                     not started (based on
> > GL_ARB_draw_elements_base_verte, which is done for all drivers)
> > > > -  GL_OES_geometry_shader                               not started (based on
> > GL_ARB_geometry_shader4, which is done for all drivers)
> > > > +  GL_OES_geometry_shader                               started (Marta)
> > > >    GL_OES_gpu_shader5                                   not started (based on parts of
> > GL_ARB_gpu_shader5, which is done for some drivers)
> > > >    GL_OES_primitive_bounding box                        not started
> > > >    GL_OES_sample_shading                                not started (based on parts of
> > GL_ARB_sample_shading, which is done for some drivers)
> > > >
> > >
> > > Not directly related with the patch, but I wonder why the
> > > GL_OES_geometry_shader entry is in the "GLES3.2 GLSL ES 3.2" section
> > > of this file. Per
> > >
> > https://www.khronos.org/registry/gles/extensions/OES/OES_geometry_sh
> > ader.txt:
> > >
> > >     "This specification is written against the OpenGL ES 3.1
> > >      (March 17, 2014) and OpenGL ES 3.10 Shading Language
> > >      (March 17, 2014) Specifications."
> > >
> > > Shouldn't this entry be moved to the previous section "GLES3.1, GLSL
> > > ES 3.1" altogether?
> > 
> > Geometry shaders were introduced with GLES 3.2, they are not part of the
> > GLES 3.1 spec, I imagine the extension has been there for a while though and
> > that's why it was written against the 3.1 spec.
> >
> GL_EXT_geometry_shader is also part of the GLES 3.1, Android Extension Pack:
> https://www.khronos.org/registry/gles/extensions/ANDROID/ANDROID_extension_pack_es31a.txt
>  
> So, if some driver wanted that we would still need to expose those extensions under GLES 3.1. 

Yeah, what I mean is that it only became part of the core spec in GL ES
3.2, so that's why I think docs/GL3.txt includes it under GLES 3.2.

> /Marta
> >
> > Iago
> > 
> > > In any case:
> > >
> > > Reviewed-by: Eduardo Lima Mitev <elima at igalia.com>
> > >
> > > _______________________________________________
> > > mesa-dev mailing list
> > > mesa-dev at lists.freedesktop.org
> > > http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> > 
> > 
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/mesa-dev