[Mesa-dev] [PATCH 0/2] Simplify nir_visitor::visit(ir_call *ir) changes for SSBO load

[Kristian Høgsberg]

On Wed, Sep 23, 2015 at 3:07 AM, Samuel Iglesias Gonsalvez
<siglesias at igalia.com> wrote:
> Following what Kristian suggested, I wrote these two patches. They are
> meant to be applied on top of:
>
>    [PATCH v5 39/70] i965/vec4: Implement __intrinsic_store_ssbo
>
> replacing:
>
>    [PATCH v5 40/70] nir: Implement __intrinsic_load_ssbo
>
> First patch moves nir_instr_insert_after_cf_list call into each case
> in the intrinsics switch at nir_visitor::visit(ir_call *ir) and
> define a nir_dest variable which will be used when handling
> ir->return_deref after the switch.
>
> Second patch adds the implementation for __intrinsic_load_ssbo and
> the final code is cleaner than the previous version of this patch.

Very nice,

Reviewed-by: Kristian Høgsberg <krh at bitplanet.net>

> Sam
>
> Iago Toral Quiroga (1):
>   nir: Implement __intrinsic_load_ssbo
>
> Samuel Iglesias Gonsalvez (1):
>   nir: modify the instruction insertion in nir_visitor::visit(ir_call
>     *ir)
>
>  src/glsl/nir/glsl_to_nir.cpp            | 79 +++++++++++++++++++++++++++++++--
>  src/glsl/nir/nir_intrinsics.h           |  2 +-
>  src/glsl/nir/nir_lower_phis_to_scalar.c |  2 +
>  3 files changed, 78 insertions(+), 5 deletions(-)
>
> --
> 2.1.4
>