[Mesa-dev] [PATCH 3/5] i965/miptree: Rename intel_miptree_map::mt -> ::linear_mt

Matt Turner mattst88 at gmail.com
Fri Sep 25 12:44:00 PDT 2015


On Fri, Sep 25, 2015 at 12:05 PM, Chad Versace <chad.versace at intel.com> wrote:
> Because that's what it is. It's an untiled, *linear* miptree.
> ---
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 27 ++++++++++++++-------------
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.h |  2 +-
>  2 files changed, 15 insertions(+), 14 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> index 1259664..29e5300 100644
> --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> @@ -2140,16 +2140,17 @@ intel_miptree_map_blit(struct brw_context *brw,
>                        struct intel_miptree_map *map,
>                        unsigned int level, unsigned int slice)
>  {
> -   map->mt = intel_miptree_create(brw, GL_TEXTURE_2D, mt->format,
> -                                  0, 0,
> -                                  map->w, map->h, 1,
> -                                  0, MIPTREE_LAYOUT_TILING_NONE);
> +   map->linear_mt = intel_miptree_create(brw, GL_TEXTURE_2D, mt->format,
> +                                         /*first, last level*/ 0, 0,

Spaces after /* and before */

I might make separate comments for each of these arguments.

> +                                         map->w, map->h, 1,
> +                                         /*samples*/ 0,

here as well.


More information about the mesa-dev mailing list