[Mesa-dev] [PATCH 2/2] egl/dri2: don't require a context for ClientWaitSync

[Albert Freeman]

On 28 September 2015 at 04:12, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 26 September 2015 at 00:49, Marek Olšák <maraeo at gmail.com> wrote:
>> From: Marek Olšák <marek.olsak at amd.com>
>>
>> The spec doesn't require it. This fixes a crash on Android.
>>
> Nicely spotted Marek.
>
> A couple of related (not supposed to be part of this patch) notes:
>  - This will just move the crash (from libEGL to i965_dri.so) for i965
> hardware :)
I rediscovered this before I read the email related to this patch
(where Marek mentions it): "Re: [Mesa-dev] Pending issues of
lollipop-x86".
Who (if anyone) should we CC this to?
>  - We really shouldn't be setting the flags if ctx is NULL, as per the spec.
>
>     "If no context is
>     current for the bound API, the EGL_SYNC_FLUSH_COMMANDS_BIT_KHR bit
>     is ignored."
Maybe handle this in the driver (probably state_tracker in the case of
gallium) level. Both here and drivers?
>
> -Emil
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev