[Mesa-dev] [PATCH 00/12] i965: Add support for 16x MSAA on SKL+

[Neil Roberts]

Neil Roberts <neil at linux.intel.com> writes:

> The following tests are failing but on my SKL device the corresponding
> tests with 8 samples are also failing. As far as I understand these
> aren't known regressions for other people so it may be something to do
> with my device being pre-production. It would be great if someone
> could test on a production device.
>
>  multisample-formats 16 gl_arb_texture_float 
>  multisample-formats 16 gl_arb_texture_rg
>  multisample-formats 16 gl_arb_texture_rg-float
>  multisample-formats 16 gl_arb_texture_rg-int 
>  multisample-formats 16 gl_ext_packed_float
>  multisample-formats 16 gl_ext_texture_integer
>  multisample-formats 16 gl_ext_texture_snorm
>  multisample-formats 16 gl_ext_texture_srgb 
>  formats 16

I realised that the only reason these are failing is that they contain
MAD instructions and my hardware is one of the ones that doesn't support
3-source SIMD16 instructions. I forgot that the workaround for this was
disabled and if I revert this patch to restore the workaround then these
start working again.

> These two tests are only failing with 16 samples but so far I haven't
> been able to figure out why. I'm hoping that these will magically pass
> on a production device.
>
>  clip-and-scissor-blit 16 msaa
>  unaligned-blit 16 color msaa

Thanks to some testing from Ben, I found these are also failing on a
production device. However I think I've found the reason so I am about
to post a patch for them.

> Jenkins is reporting some unstable tests on g45 and g965 but they
> don't seem related so I'm a bit confused.

This has stopped happening so presumably it was unrelated.

Regards,
- Neil