[Mesa-dev] [PATCH v5 2/3] mesa: Move _mesa_base_tex_format() from teximage to glformats files

Emil Velikov emil.l.velikov at gmail.com
Mon Sep 28 13:11:44 PDT 2015


Hi Eduardo,

On 24 September 2015 at 09:57, Eduardo Lima Mitev <elima at igalia.com> wrote:
> This function will be needed as part of validating the combination of format,
> type and internal format of texture pixel operations, which happens in
> glformats files. Specifically, we want to be able to obtain the base format
> of a resolved effective internal format, to compare it with the original
> internal format passed.
>
> Also, since this function deals solely with GL formats, it fits better in
> glformats where the rest of similar format functionality rests.
>
> The function is moved as-is, without any modification.
>
> Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>
> Cc: "11.0" <mesa-stable at lists.freedesktop.org>
Please for the future, keep re-factoring commits after/separate from
bugfixes. When possible of course.

Also can you and your fellow colleagues take a look at patchwork [1]
and mark your patches as accepted, superseded, rejected, etc. The
person sending the patches can change their status, once registered
with the same email address.

Thank you
Emil

[1] http://patchwork.freedesktop.org/project/mesa/list/


More information about the mesa-dev mailing list