[Mesa-dev] [PATCH 25/24] glsl: add std140 layout support for AoA

[Timothy Arceri]

On Thu, 2015-09-24 at 11:31 +0200, Samuel Iglesias Gonsálvez wrote:
> 
> On 24/09/15 02:16, Timothy Arceri wrote:
> > On Wed, 2015-09-23 at 13:21 +0200, Samuel Iglesias Gonsálvez wrote:
> > > On 22/09/15 15:30, Samuel Iglesias Gonsálvez wrote:
> > > > Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
> > > > 
> > > 
> > > Forgot to say that we need to implement a similar patch for
> > > std430_size() function, right?
> > 
> > Yeah I think so.
> > 
> > > 
> > > I will write a follow-up patch adding std430 support for AoA.
> > 
> > That would be great thanks.
> > 
> > I assume there will also be other places in the SSBO series that
> > might
> > need updates for AoA?
> > 
> 
> As I am not very familiar with AoA, I will need to check how AoA
> affects
> to SSBO-related code.
> 
> I plan to look at it soon and send follow-up patches (if needed). I
> might ask you to review my patches as you have implemented AoA.

Hi Samuel,

Have you started looking at this yet?

If not I might start looking at it tomorrow. I'm hoping its a case of
things mostly just working but at the least we may need a few extra
piglit tests.

Tim