[Mesa-dev] [PATCH] nir: Don't set dest in SSBO store glsl_to_nir conversion
Samuel Iglesias Gonsálvez
siglesias at igalia.com
Mon Sep 28 23:49:52 PDT 2015
On 28/09/15 23:47, Jordan Justen wrote:
> This matches the function signature created in
> lower_ubo_reference_visitor::ssbo_store which has a void return.
True! Good catch.
Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
Thanks,
Sam
>
> Suggested-by: Jason Ekstrand <jason at jlekstrand.net>
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> Cc: Samuel Iglesias Gonsalvez <siglesias at igalia.com>
> Cc: Jason Ekstrand <jason at jlekstrand.net>
> ---
> src/glsl/nir/glsl_to_nir.cpp | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp
> index cb379ad..6132b82 100644
> --- a/src/glsl/nir/glsl_to_nir.cpp
> +++ b/src/glsl/nir/glsl_to_nir.cpp
> @@ -799,7 +799,6 @@ nir_visitor::visit(ir_call *ir)
> instr = nir_intrinsic_instr_create(shader, op);
> instr->src[2] = evaluate_rvalue(offset);
> instr->const_index[0] = 0;
> - dest = &instr->dest;
> } else {
> instr->const_index[0] = const_offset->value.u[0];
> }
>
More information about the mesa-dev
mailing list