[Mesa-dev] [PATCH 4/5] i965/miptree: Rename align_w, align_h -> halign, valign

[Ben Widawsky]

On Tue, Sep 29, 2015 at 02:16:04PM -0700, Chad Versace wrote:
> On Sun 27 Sep 2015, Ben Widawsky wrote:
> > On Fri, Sep 25, 2015 at 12:05:49PM -0700, Chad Versace wrote:
> > > The values of intel_mipmap_tree::align_w and ::align_h correspond to the
> > > hardware enums HALIGN_* and VALIGN_*.
> > > 
> > > See the confusion?
> > >     align_h != HALIGN
> > >     align_h == VALIGN
> > > 
> > > Reduce the confusion by renaming the variables to match the hardware
> > > enum names:
> > >     git ls-files |
> > >     xargs sed -i -e 's/align_w/halign/g' \
> > >                  -e 's/align_h/valign/g'
> > > 
> > > Suggested-by: Kenneth Graunke <kenneth at whitecape.org>
> > > Cc: Ben Widawsky <ben at bwidawsk.net>
> > > Cc: Kenneth Graunke <kenneth at whitecape.org>
> > > ---
> > >  src/mesa/drivers/dri/i965/brw_tex_layout.c        | 62 +++++++++++------------
> > >  src/mesa/drivers/dri/i965/brw_wm_surface_state.c  |  4 +-
> > >  src/mesa/drivers/dri/i965/gen6_blorp.cpp          |  2 +-
> > >  src/mesa/drivers/dri/i965/gen6_surface_state.c    |  2 +-
> > >  src/mesa/drivers/dri/i965/gen7_blorp.cpp          |  4 +-
> > >  src/mesa/drivers/dri/i965/gen7_wm_surface_state.c |  8 +--
> > >  src/mesa/drivers/dri/i965/gen8_surface_state.c    | 12 ++---
> > >  src/mesa/drivers/dri/i965/intel_mipmap_tree.c     |  2 +-
> > >  src/mesa/drivers/dri/i965/intel_mipmap_tree.h     | 18 +++++--
> > >  9 files changed, 62 insertions(+), 52 deletions(-)
> 
> 
> > Reviewed-by: Ben Widawsky <ben at bwidawsk.net>
> 
> Is this a rb for only this patch? Or for the series?

It was just this. I haven't had time to look at the others in any detail, but
you can add my Acked-by on those if you'd like. The idea is sound.

-- 
Ben Widawsky, Intel Open Source Technology Center