[Mesa-dev] [PATCH 2/2] i965: Get rid of prog_data compare functions

[Kenneth Graunke]

On Tuesday, September 29, 2015 09:05:41 PM Jason Ekstrand wrote:
> They are no longer used.
> ---
>  src/mesa/drivers/dri/i965/brw_context.h | 26 --------------------------
>  src/mesa/drivers/dri/i965/brw_cs.c      | 21 ---------------------
>  src/mesa/drivers/dri/i965/brw_cs.h      |  2 --
>  src/mesa/drivers/dri/i965/brw_gs.c      | 21 ---------------------
>  src/mesa/drivers/dri/i965/brw_gs.h      |  2 --
>  src/mesa/drivers/dri/i965/brw_program.c | 17 -----------------
>  src/mesa/drivers/dri/i965/brw_program.h |  4 ----
>  src/mesa/drivers/dri/i965/brw_vs.c      | 21 ---------------------
>  src/mesa/drivers/dri/i965/brw_vs.h      |  1 -
>  src/mesa/drivers/dri/i965/brw_wm.c      | 19 -------------------
>  src/mesa/drivers/dri/i965/brw_wm.h      |  1 -
>  11 files changed, 135 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/drivers/dri/i965/brw_context.h
> index 3bae90d..bf4deaa 100644
> --- a/src/mesa/drivers/dri/i965/brw_context.h
> +++ b/src/mesa/drivers/dri/i965/brw_context.h
> @@ -340,9 +340,6 @@ struct brw_shader {
>     bool compiled_once;
>  };
>  
> -/* Note: If adding fields that need anything besides a normal memcmp() for
> - * comparing them, be sure to go fix brw_stage_prog_data_compare().
> - */
>  struct brw_stage_prog_data {
>     struct {
>        /** size of our binding table. */
> @@ -378,18 +375,10 @@ struct brw_stage_prog_data {
>  
>     /* Pointers to tracked values (only valid once
>      * _mesa_load_state_parameters has been called at runtime).
> -    *
> -    * These must be the last fields of the struct (see
> -    * brw_stage_prog_data_compare()).
>      */
>     const gl_constant_value **param;
>     const gl_constant_value **pull_param;
>  
> -   /**
> -    * Image metadata passed to the shader as uniforms.  This is deliberately

Please keep this first sentence.  Otherwise, both are
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

> -    * ignored by brw_stage_prog_data_compare() because its contents don't have
> -    * any influence on program compilation.
> -    */
>     struct brw_image_param *image_param;
>  };
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150929/6699028d/attachment.sig>