[Mesa-dev] [PATCH 08/70] i965: Remove early release of DRI2 miptree

[Martin Peres]

On 30/09/15 00:26, Chad Versace wrote:
> On Mon 28 Sep 2015, Martin Peres wrote:
>> On 28/09/15 17:27, Emil Velikov wrote:
>>> Hi all,
>>>
>>> On 17 August 2015 at 19:06, Chad Versace <chad.versace at intel.com> wrote:
>>>> On Fri 14 Aug 2015, Chris Wilson wrote:
>>>>> On Thu, Aug 13, 2015 at 09:58:52PM -0700, Kenneth Graunke wrote:
>>>>>> On Thursday, August 13, 2015 02:57:20 PM Martin Peres wrote:
>>>>>>> On 07/08/15 23:13, Chris Wilson wrote:
>>>>>>>> intel_update_winsys_renderbuffer_miptree() will release the existing
>>>>>>>> miptree when wrapping a new DRI2 buffer, so we can remove the early
>>>>>>>> release and so prevent a NULL mt dereference should importing the new
>>>>>>>> DRI2 name fail for any reason. (Reusing the old DRI2 name will result
>>>>>>>> in the rendering going astray, to a stale buffer, and not shown on the
>>>>>>>> screen, but it allows us to issue a warning and not crash much later in
>>>>>>>> innocent code.)
>>>>>>>>
>>>>>>>> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
>>>>>>>> ---
>>>>>>>>    src/mesa/drivers/dri/i965/brw_context.c | 1 -
>>>>>>>>    1 file changed, 1 deletion(-)
>
>>> As I haven't been following the discussion, can anyone point me to the
>>> solution (if any) on this topic ?
>>> Archlinux seems to be using the original "remove early release..."
>>> alongside 10.6 and 11.0 as it is still an issue [1]. On the other hand
>>> I've not seen any other distro picking it/any fixes on top of the
>>> upstream tarball.
>>>
>>> Thanks
>>> Emil
>>>
>>> [1] https://bugs.archlinux.org/task/45750
>> I would be in favour of merging this patch right now. It is partial and will
>> require more work to handle more cases but this is already a huge
>> improvement for kde users.
> I agree. This patch does not eliminate all crashes, but's still a large
> improvement. And the logic in the commit message is sound.
>
> Reviewed-by: Chad Versace <chad.versace at intel.com>

Thanks Chad, I've merged the patch. I think we need to backport it to 
all the maintained branches. Emil?