[Mesa-dev] [PATCH v2 7/7] nir/instr_set: remove unnecessary check in nir_instrs_equal()
Connor Abbott
cwabbott0 at gmail.com
Wed Sep 30 08:12:02 PDT 2015
This was originally added to nir_instrs_equal() instead of
nir_instr_can_cse() incorrectly, but this was fixed when moving to the
instruction set API (as it had to be, otherwise hashing wouldn't work).
Now, this is dead code since instr_can_rewrite() will only return true
for texture instructions that use an index, so we can turn the check into
an assert. This also means that now nir_instrs_equal(instr, instr) will
always return true unless it assert-fails.
Signed-off-by: Connor Abbott <cwabbott0 at gmail.com>
---
src/glsl/nir/nir_instr_set.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/glsl/nir/nir_instr_set.c b/src/glsl/nir/nir_instr_set.c
index 007d6cb..669a937 100644
--- a/src/glsl/nir/nir_instr_set.c
+++ b/src/glsl/nir/nir_instr_set.c
@@ -308,8 +308,7 @@ nir_instrs_equal(const nir_instr *instr1, const nir_instr *instr2)
}
/* Don't support un-lowered sampler derefs currently. */
- if (tex1->sampler || tex2->sampler)
- return false;
+ assert(!tex1->sampler && !tex2->sampler);
return true;
}
--
2.1.0
More information about the mesa-dev
mailing list