[Mesa-dev] [PATCH] i965: Remove duplicate copy of is_scalar_shader_stage().

Matt Turner mattst88 at gmail.com
Wed Sep 30 10:08:05 PDT 2015


On Wed, Sep 30, 2015 at 9:59 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> Jason open coded this in 60befc63 when cleaning up some ugly code;
> using our existing helper tidies it up a bit more.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/brw_shader.cpp | 51 +++++++++++++-------------------
>  1 file changed, 20 insertions(+), 31 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp
> index 785cb27..cdc7819 100644
> --- a/src/mesa/drivers/dri/i965/brw_shader.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_shader.cpp
> @@ -72,6 +72,20 @@ shader_perf_log_mesa(void *data, const char *fmt, ...)
>     va_end(args);
>  }
>
> +static inline bool

I don't think you want inline here (it's static and only used in this
file, so the compiler can decide what to do), but otherwise

Reviewed-by: Matt Turner <mattst88 at gmail.com>


More information about the mesa-dev mailing list