[Mesa-dev] [PATCH v2] mesa: Fix format specifier warning in mesa_DispatchComputeIndirect()

Jordan Justen jordan.l.justen at intel.com
Wed Sep 30 10:22:07 PDT 2015


Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
and committed.

On 2015-09-30 06:18:52, Rhys Kidd wrote:
> Commit 1665d29ee3125743fd6daf3c43fc715f543d5669 introduced an incorrect
> format specifier that operates on GLintptr indirect within the function
> _mesa_DispatchComputeIndirect().
> 
> This patch mitigates the introduced GCC warning:
> 
> src/mesa/main/compute.c: In function '_mesa_DispatchComputeIndirect':
> src/mesa/main/compute.c:53:7: warning: format '%d' expects argument of type 'int', but argument 3 has type 'GLintptr' [-Wformat=]
>        _mesa_debug(ctx, "glDispatchComputeIndirect(%d)\n", indirect);
>            ^
> 
> v2: Amend for Boyan Ding <boyan.j.ding at gmail.com> feedback.
> Signed-off-by: Rhys Kidd <rhyskidd at gmail.com>
> ---
>  src/mesa/main/compute.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/main/compute.c b/src/mesa/main/compute.c
> index 8bc3bcd..53e7a50 100644
> --- a/src/mesa/main/compute.c
> +++ b/src/mesa/main/compute.c
> @@ -50,7 +50,7 @@ _mesa_DispatchComputeIndirect(GLintptr indirect)
>     GET_CURRENT_CONTEXT(ctx);
>  
>     if (MESA_VERBOSE & VERBOSE_API)
> -      _mesa_debug(ctx, "glDispatchComputeIndirect(%d)\n", indirect);
> +      _mesa_debug(ctx, "glDispatchComputeIndirect(%ld)\n", (long) indirect);
>  
>     if (!_mesa_validate_DispatchComputeIndirect(ctx, indirect))
>        return;
> -- 
> 2.1.4
> 


More information about the mesa-dev mailing list