[Mesa-dev] [PATCH] i965/vec4: copy abs/negate modifiers on src/dst_reg conversion constructors

[Jason Ekstrand]

I'm not sure if this makes sense.  I can see how it would be useful
(less information lost when going src_reg -> dst_reg -> src_reg).
However, it seems wrong to me to assume that dst_reg.abs or
dst_reg.negate means anything useful.  Matt?
--Jason

On Wed, Sep 30, 2015 at 10:32 AM, Alejandro Piñeiro
<apinheiro at igalia.com> wrote:
> ---
>  src/mesa/drivers/dri/i965/brw_vec4.cpp | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp
> index c61b385..121e698 100644
> --- a/src/mesa/drivers/dri/i965/brw_vec4.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_vec4.cpp
> @@ -139,6 +139,8 @@ src_reg::src_reg(const dst_reg &reg)
>     this->reladdr = reg.reladdr;
>     this->fixed_hw_reg = reg.fixed_hw_reg;
>     this->swizzle = brw_swizzle_for_mask(reg.writemask);
> +   this->negate = reg.negate;
> +   this->abs = reg.abs;
>  }
>
>  void
> @@ -204,6 +206,8 @@ dst_reg::dst_reg(const src_reg &reg)
>     this->writemask = brw_mask_for_swizzle(reg.swizzle);
>     this->reladdr = reg.reladdr;
>     this->fixed_hw_reg = reg.fixed_hw_reg;
> +   this->abs = reg.abs;
> +   this->negate = reg.negate;
>  }
>
>  bool
> --
> 2.1.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev