[Mesa-dev] [PATCH v3 12/12] nvc0: enable compute shaders on GK104 and GM107+

Ilia Mirkin imirkin at alum.mit.edu
Fri Apr 1 17:29:41 UTC 2016


On Fri, Apr 1, 2016 at 12:56 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> Compute support on GK110 is still unstable for weird reasons, but
> this can be fixed later as the NVF0_COMPUTE envvar prevent using
> compute.
>
> Note that GL3.txt is not updated yet because GL_ARB_compute_shader is
> a bit useless without ARB_shader_image_load_store.

I'd drop this comment, but meh.

>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
> index ac7f57b..6a11e66 100644
> --- a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
> +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
> @@ -291,7 +291,7 @@ nvc0_screen_get_shader_param(struct pipe_screen *pscreen, unsigned shader,
>     case PIPE_SHADER_CAP_PREFERRED_IR:
>        return PIPE_SHADER_IR_TGSI;
>     case PIPE_SHADER_CAP_SUPPORTED_IRS:
> -      if (class_3d >= NVE4_3D_CLASS)
> +      if (class_3d == NVF0_3D_CLASS)

You could do

if (class_3d == NVF0_3D_CLASS && !debug_get_bool_option("NVF0_COMPUTE", false))

Either way,

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

>           return 0;
>        return 1 << PIPE_SHADER_IR_TGSI;
>     case PIPE_SHADER_CAP_MAX_INSTRUCTIONS:
> --
> 2.7.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list