[Mesa-dev] [PATCH 2/2] Differentiate between DeleteQueries and DeleteQueriesARB

Emil Velikov emil.l.velikov at gmail.com
Wed Apr 6 18:59:58 UTC 2016

Hi Kevin,

On 5 April 2016 at 12:27,  <kevin.rogovin at intel.com> wrote:
> From: Kevin Rogovin <kevin.rogovin at intel.com>
> The extension, GL_ARB_occlusion_queries
typo -> ...query (same goes for patch 1/2)

> mandates that an
> INVALID_OPERATION should be thrown if DeleteQueriesARB is
> called while a query is active. In contrast, the GL spec
> has no such requirement for DeleteQueries. This patch
> unaliases the two functions and has that the ARB variant
> performs that extra check.
Please correct me if I'm wrong, but I think we cannot unalias
functions once they're in. It will break the backwards compatibility
we're trying to manage with glapi. If we want to retain it we should
opt for the least likely to hit solution ?

> --- a/src/mesa/main/context.c
> +++ b/src/mesa/main/context.c
> @@ -1090,6 +1090,7 @@ create_beginend_table(const struct gl_context *ctx)
>     COPY_DISPATCH(IsTexture);
>     COPY_DISPATCH(IsTransformFeedback);
>     COPY_DISPATCH(DeleteQueries);
> +   COPY_DISPATCH(DeleteQueriesARB);
Either I'm misreading the comment above the function or this doesn't
belong here.


More information about the mesa-dev mailing list