[Mesa-dev] [PATCH] radeonsi: fix mask checking when emitting scissors and viewports

[Marek Olšák]

On Fri, Apr 8, 2016 at 12:16 PM,  <eocallaghan at alterapraxis.com> wrote:
> On 2016-04-08 19:00, Marek Olšák wrote:
>>
>> From: Marek Olšák <marek.olsak at amd.com>
>>
>> ---
>>  src/gallium/drivers/radeonsi/si_state.c | 12 ++++++++----
>>  1 file changed, 8 insertions(+), 4 deletions(-)
>>
>> diff --git a/src/gallium/drivers/radeonsi/si_state.c
>> b/src/gallium/drivers/radeonsi/si_state.c
>> index 8087d23..3894e1d 100644
>> --- a/src/gallium/drivers/radeonsi/si_state.c
>> +++ b/src/gallium/drivers/radeonsi/si_state.c
>> @@ -912,8 +912,10 @@ static void si_emit_scissors(struct si_context
>> *sctx, struct r600_atom *atom)
>>         bool scissor_enable =
>> sctx->queued.named.rasterizer->scissor_enable;
>>
>>         /* The simple case: Only 1 viewport is active. */
>> -       if (mask & 1 &&
>> -           !si_get_vs_info(sctx)->writes_viewport_index) {
>> +       if (!si_get_vs_info(sctx)->writes_viewport_index) {
>> +               if (!(mask & 1))
>
>
> seems a bit tentative.. did you want 1u here or?

1 and 1u are equivalent in this case.

Marek