[Mesa-dev] [PATCH 2/4] nir: Silence unused "options" warning in algebraic passes.
Eduardo Lima Mitev
elima at igalia.com
Fri Apr 8 15:26:22 UTC 2016
On 04/08/2016 01:35 AM, Kenneth Graunke wrote:
> Some passes may not refer to options->..., at which point the compiler
> will warn about an unused variable. Just cast to void unconditionally
> to shut it up.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
> src/compiler/nir/nir_algebraic.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/compiler/nir/nir_algebraic.py b/src/compiler/nir/nir_algebraic.py
> index d05564f..53a7907 100644
> --- a/src/compiler/nir/nir_algebraic.py
> +++ b/src/compiler/nir/nir_algebraic.py
> @@ -291,6 +291,7 @@ ${pass_name}(nir_shader *shader)
> bool progress = false;
> bool condition_flags[${len(condition_list)}];
> const nir_shader_compiler_options *options = shader->options;
> + (void) options;
>
Hmm, don't like this very much. I suppose since it is generated code, it
can not be done per block where options is unused.
For respect to other people's right to have clean build logs, patch is:
Reviewed-by: Eduardo Lima Mitev <elima at igalia.com>
> % for index, condition in enumerate(condition_list):
> condition_flags[${index}] = ${condition};
>
More information about the mesa-dev
mailing list