[Mesa-dev] [PATCH 2/4] i965/tiled_memcpy: Move SSSE3 code back into inline functions.

[Roland Scheidegger]

Am 12.04.2016 um 02:03 schrieb Matt Turner:
> On Mon, Apr 11, 2016 at 4:17 PM, Roland Scheidegger <sroland at vmware.com> wrote:
>> I thought void ptr arithmetic is illegal (though a gcc extension), so
>> maybe should avoid that?
> 
> Right, it's a GNU C extension. I was aware I was using it, and I think
> it makes the code a lot nicer here, avoiding some casts or extra
> variables.
> 

Well, I think it would generate warnings if you use -Wpedantic or some
such, so some people might be annoyed by it. But I certainly don't
really care (especially if it's used already), by the looks of it clang
+ icc will compile it just fine too.
Not sure I agree it makes the code really nicer - I could certainly see
some argument that a typeless pointer having size 1 per element is a bit
odd (but then again a void pointer is mostly equivalent to a byte pointer).

Roland