[Mesa-dev] [PATCH 05/10] radeonsi: fix calls to r600 functions that take endian_format

Oded Gabbay oded.gabbay at gmail.com
Tue Apr 12 07:00:01 UTC 2016


On Tue, Apr 12, 2016 at 12:17 AM, Marek Olšák <maraeo at gmail.com> wrote:
>
> This should be squashed with the patch changing those function signatures.
>
> Marek
Yes, of course you are correct here.
Oded

>
> On Mon, Apr 11, 2016 at 4:34 PM, Oded Gabbay <oded.gabbay at gmail.com> wrote:
> > radeonsi calls some r600 functions that now receive the endian_format
> > value as a parameter, so we need to fix the calls to prevent compilation
> > errors.
> >
> > Signed-off-by: Oded Gabbay <oded.gabbay at gmail.com>
> > ---
> >  src/gallium/drivers/radeonsi/si_state.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c
> > index 8087d23..11f7469 100644
> > --- a/src/gallium/drivers/radeonsi/si_state.c
> > +++ b/src/gallium/drivers/radeonsi/si_state.c
> > @@ -2042,7 +2042,7 @@ static bool si_is_vertex_format_supported(struct pipe_screen *screen, enum pipe_
> >  static bool si_is_colorbuffer_format_supported(enum pipe_format format)
> >  {
> >         return si_translate_colorformat(format) != V_028C70_COLOR_INVALID &&
> > -               r600_translate_colorswap(format) != ~0U;
> > +               r600_translate_colorswap(format, PIPE_ENDIAN_NATIVE) != ~0U;
> >  }
> >
> >  static bool si_is_zs_format_supported(enum pipe_format format)
> > @@ -2335,7 +2335,7 @@ static void si_initialize_color_surface(struct si_context *sctx,
> >                 R600_ERR("Invalid CB format: %d, disabling CB.\n", surf->base.format);
> >         }
> >         assert(format != V_028C70_COLOR_INVALID);
> > -       swap = r600_translate_colorswap(surf->base.format);
> > +       swap = r600_translate_colorswap(surf->base.format, PIPE_ENDIAN_NATIVE);
> >         endian = si_colorformat_endian_swap(format);
> >
> >         /* blend clamp should be set for all NORM/SRGB types */
> > --
> > 2.5.5
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list