[Mesa-dev] [PATCH] glsl: Update hash table comments in constant propagation

Kenneth Graunke kenneth at whitecape.org
Tue Apr 12 08:29:44 UTC 2016


On Sunday, April 10, 2016 8:43:25 PM PDT Rhys Kidd wrote:
> Signed-off-by: Rhys Kidd <rhyskidd at gmail.com>
> ---
>  src/compiler/glsl/opt_constant_propagation.cpp | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/compiler/glsl/opt_constant_propagation.cpp b/src/compiler/
glsl/opt_constant_propagation.cpp
> index 416ba16..4764d16 100644
> --- a/src/compiler/glsl/opt_constant_propagation.cpp
> +++ b/src/compiler/glsl/opt_constant_propagation.cpp
> @@ -122,7 +122,7 @@ public:
>     exec_list *acp;
>  
>     /**
> -    * List of kill_entry: The masks of variables whose values were
> +    * Hash table of kill_entry: The masks of variables whose values were
>      * killed in this block.
>      */
>     hash_table *kills;
> @@ -454,7 +454,7 @@ ir_constant_propagation_visitor::kill(ir_variable *var, 
unsigned write_mask)
>        }
>     }
>  
> -   /* Add this writemask of the variable to the list of killed
> +   /* Add this writemask of the variable to the hash table of killed
>      * variables in this block.
>      */
>     hash_entry *kill_hash_entry = _mesa_hash_table_search(this->kills, var);
> @@ -463,7 +463,7 @@ ir_constant_propagation_visitor::kill(ir_variable *var, 
unsigned write_mask)
>        entry->write_mask |= write_mask;
>        return;
>     }
> -   /* Not already in the list.  Make new entry. */
> +   /* Not already in the hash table.  Make new entry. */
>     _mesa_hash_table_insert(this->kills, var,
>                             new(this->mem_ctx) kill_entry(var, write_mask));
>  }
> 

Pushed, thanks!

--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20160412/8293bb77/attachment.sig>


More information about the mesa-dev mailing list