[Mesa-dev] [PATCH] scons: Build NIR.

[Rob Clark]

On Mon, Apr 11, 2016 at 8:50 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 10 April 2016 at 00:19, Rob Clark <robdclark at gmail.com> wrote:
>> On Sat, Apr 9, 2016 at 7:16 PM, Rob Clark <robdclark at gmail.com> wrote:
>>> From: Jose Fonseca <jfonseca at vmware.com>
>>>
>>> Signed-off-by: Rob Clark <robclark at freedesktop.org>
>>> ---
>>
>> I should have added that this was originally Jose's patch and I
>> rebased on the src/compiler move..
>>
>> he had additional patches to make NIR build w/ MSVC, but this is
>> enough (with one additional bit squashed into mesa/st NIR patch) to
>> make scons build for linux work with my gallium NIR patchset.
>>
> A small suggestion - can you please move the NIR into SConscript.nir
> just like the GLSL one [1] ? The naming scheme is not perfect, yet it
> allows us to have small scripts, which should be easier to parse.

I hope you don't mind if I leave that as a TODO for someone else to
deal with.. I still have a backlog of updates for the gallium-nir
patchset and other patchsets that I have in flight so not really
trying to take on extra refactoring of a build system that I really
know little about ;-)

BR,
-R

> On the Windows testing side - just login/signup to travis-ci (with
> your github account) and add your mesa repo. It should get tested on
> your next push.
> Alternatively I can take a look ;-)
>
> -Emil
>
> [1] https://lists.freedesktop.org/archives/mesa-dev/2016-April/111927.html