[Mesa-dev] [PATCH 33/47] nir/opt_undef: fixup for new foreach_block()

Connor Abbott cwabbott0 at gmail.com
Wed Apr 13 04:35:12 UTC 2016


Signed-off-by: Connor Abbott <cwabbott0 at gmail.com>
---
 src/compiler/nir/nir_opt_undef.c | 23 ++++++++---------------
 1 file changed, 8 insertions(+), 15 deletions(-)

diff --git a/src/compiler/nir/nir_opt_undef.c b/src/compiler/nir/nir_opt_undef.c
index 374564d..3ceb120 100644
--- a/src/compiler/nir/nir_opt_undef.c
+++ b/src/compiler/nir/nir_opt_undef.c
@@ -71,20 +71,6 @@ opt_undef_alu(nir_alu_instr *instr)
    return false;
 }
 
-static bool
-opt_undef_block(nir_block *block, void *data)
-{
-   bool *progress = data;
-
-   nir_foreach_instr_safe(block, instr) {
-      if (instr->type == nir_instr_type_alu)
-         if (opt_undef_alu(nir_instr_as_alu(instr)))
-             (*progress) = true;
-   }
-
-   return true;
-}
-
 bool
 nir_opt_undef(nir_shader *shader)
 {
@@ -92,7 +78,14 @@ nir_opt_undef(nir_shader *shader)
 
    nir_foreach_function(shader, function) {
       if (function->impl) {
-         nir_foreach_block(function->impl, opt_undef_block, &progress);
+         nir_foreach_block(function->impl, block) {
+            nir_foreach_instr_safe(block, instr) {
+               if (instr->type == nir_instr_type_alu)
+                  if (opt_undef_alu(nir_instr_as_alu(instr)))
+                      progress = true;
+            }
+         }
+
          if (progress)
             nir_metadata_preserve(function->impl,
                                   nir_metadata_block_index |
-- 
2.5.0



More information about the mesa-dev mailing list