[Mesa-dev] Fwd: New Defects reported by Coverity Scan for Mesa

[Matt Turner]

Looks like some locking problems caused by commit 70299474. Please take a look.

---------- Forwarded message ----------
From:  <scan-admin at coverity.com>
Date: Wed, Apr 13, 2016 at 8:37 AM
Subject: New Defects reported by Coverity Scan for Mesa

________________________________________________________________________________________________________
*** CID 1358496:    (LOCK)
/src/egl/drivers/dri2/egl_dri2.c: 2643 in dri2_client_wait_sync()
2637
2638      cleanup:
2639        dri2_egl_unref_sync(dri2_dpy, dri2_sync);
2640
2641        if (ret == EGL_FALSE) {
2642           _eglError(EGL_BAD_ACCESS, "eglClientWaitSyncKHR");
>>>     CID 1358496:    (LOCK)
>>>     Returning without unlocking "dri2_sync->mutex".
2643           return EGL_FALSE;
2644        }
2645
2646        return ret;
2647     }
2648
/src/egl/drivers/dri2/egl_dri2.c: 2643 in dri2_client_wait_sync()
2637
2638      cleanup:
2639        dri2_egl_unref_sync(dri2_dpy, dri2_sync);
2640
2641        if (ret == EGL_FALSE) {
2642           _eglError(EGL_BAD_ACCESS, "eglClientWaitSyncKHR");
>>>     CID 1358496:    (LOCK)
>>>     Returning without unlocking "dri2_sync->mutex".
2643           return EGL_FALSE;
2644        }
2645
2646        return ret;
2647     }
2648