[Mesa-dev] [RFC 22/24] nvc0: inform users that 3D images are not fully supported

[Ilia Mirkin]

I would recommend using a pipe_debug_message here as well. Either way,

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

On Tue, Apr 12, 2016 at 7:57 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> 3D images are a bit more complicated to implement and will probably
> requires a bunch of headaches and we don't care for now because they
> do not seem to be really used by apps.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/gallium/drivers/nouveau/nvc0/nvc0_tex.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_tex.c b/src/gallium/drivers/nouveau/nvc0/nvc0_tex.c
> index 49a78b5..bb4ebd2 100644
> --- a/src/gallium/drivers/nouveau/nvc0/nvc0_tex.c
> +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_tex.c
> @@ -889,7 +889,8 @@ nve4_set_surface_info(struct nouveau_pushbuf *push,
>           if (mt->layout_3d) {
>              address += nvc0_mt_zslice_offset(mt, view->u.tex.level, z);
>              /* doesn't work if z passes z-tile boundary */
> -            assert(depth == 1);
> +            if (depth > 1)
> +               debug_printf("3D images are not really supported!");
>           } else {
>              address += mt->layer_stride * z;
>           }
> --
> 2.8.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev