[Mesa-dev] [PATCH 1/3] glsl: removing double semi-colons

[Jakob Sinclair]

On 2016-04-14 00:43, Ian Romanick wrote:
> It looks like there are a couple other instances dangling around the
> tree. src/glx/dri2_glx.c, src/mesa/math/m_debug_norm.c, etc.
> 
> I did 'grep -r ';[[:space:]]*;' src/'.  Most of the hits were 
> for-loops.
> 
> On 04/13/2016 09:43 AM, Jakob Sinclair wrote:
>> Trivial change. Removing unnecessary semi-colons from the code.
>> I don't have push access so someone reviewing this can push it.
>> 
>> Signed-off-by: Jakob Sinclair <sinclair.jakob at openmailbox.org>
>> ---
>>  src/compiler/glsl/ast_function.cpp      | 2 +-
>>  src/compiler/glsl/ir_rvalue_visitor.cpp | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/src/compiler/glsl/ast_function.cpp 
>> b/src/compiler/glsl/ast_function.cpp
>> index db68d5d..f50c7bf 100644
>> --- a/src/compiler/glsl/ast_function.cpp
>> +++ b/src/compiler/glsl/ast_function.cpp
>> @@ -1690,7 +1690,7 @@ process_record_constructor(exec_list 
>> *instructions,
>>                            constructor_type->fields.structure[i].name,
>>                            ir->type->name,
>>                            
>> constructor_type->fields.structure[i].type->name);
>> -         return ir_rvalue::error_value(ctx);;
>> +         return ir_rvalue::error_value(ctx);
>>        }
>> 
>>        node = node->next;
>> diff --git a/src/compiler/glsl/ir_rvalue_visitor.cpp 
>> b/src/compiler/glsl/ir_rvalue_visitor.cpp
>> index 6ab6cf0..addcc68 100644
>> --- a/src/compiler/glsl/ir_rvalue_visitor.cpp
>> +++ b/src/compiler/glsl/ir_rvalue_visitor.cpp
>> @@ -146,7 +146,7 @@ ir_rvalue_base_visitor::rvalue_visit(ir_discard 
>> *ir)
>>  ir_visitor_status
>>  ir_rvalue_base_visitor::rvalue_visit(ir_return *ir)
>>  {
>> -   handle_rvalue(&ir->value);;
>> +   handle_rvalue(&ir->value);
>>     return visit_continue;
>>  }
>> 
>> 

Oh, I must have missed those. But these patches can be pushed and I can 
submit a new patch where I remove those semi-colons that are still left 
in the code. I don't have push access though so If you think these 
patches are ok can you push them for me? Thanks.

-- 
Mvh Jakob Sinclair.